Change in flashrom[master]: spi25_statusreg: make register read/write functions generic - flashrom-gerrit

11 Jan 2022


      Attention is currently required from: Nico Huber, Angel Pons, Sergii Dmytruk.
Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58475 )
Change subject: spi25_statusreg: make register read/write functions generic
......................................................................
Patch Set 17:
(1 comment)
File spi25_statusreg.c:
https://review.coreboot.org/c/flashrom/+/58475/comment/6ec031a7_380602c3 
PS15, Line 63: 	 */
...
I'm inclined to agree, this code dates back to 2010 in commit 174f55bdec62, which doesn't mention an […]
Changed in latest patch set.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/58475
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0a3951bbf993f2d8d830143b29d3ce16cc6901d7
Gerrit-Change-Number: 58475
Gerrit-PatchSet: 17
Gerrit-Owner: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Tue, 11 Jan 2022 04:47:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Nikolai Artemiev nartemiev@google.com
Gerrit-MessageType: comment