Change in flashrom[master]: Add AmigaOS suppport to flashrom - flashrom-gerrit

14 Jul 2021


      Attention is currently required from: Stefan Reinauer, Paul Menzel, Angel Pons.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54943 )
Change subject: Add AmigaOS suppport to flashrom
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/54943/comment/d8d7aec5_b4783c18 
PS1, Line 137: 
             : ifeq ($(TARGET_OS), AmigaOS)
Can you add meson support as well?
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/54943/comment/f7153ca4_f416b430 
PS1, Line 162: *argv[]
...
Yep. […]
Is there any reason this shouldn't be const anyway?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/54943
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3e4a3885f88313aad019454fdbdf4be176b35330
Gerrit-Change-Number: 54943
Gerrit-PatchSet: 1
Gerrit-Owner: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 14 Jul 2021 11:34:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Stefan Reinauer stefan.reinauer@coreboot.org
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment