Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/40679 )
Change subject: lspcon_i2c_spi.c: Trivial style fix ......................................................................
lspcon_i2c_spi.c: Trivial style fix
Change-Id: I0675b467d7b0d24626a336033668bf80bfeeb815 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M lspcon_i2c_spi.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/40679/1
diff --git a/lspcon_i2c_spi.c b/lspcon_i2c_spi.c index 1ee5f37..8de2c14 100644 --- a/lspcon_i2c_spi.c +++ b/lspcon_i2c_spi.c @@ -151,7 +151,7 @@ int ret = 0; do { ret |= lspcon_i2c_spi_read_register(fd, offset, &val); - } while(!ret && (val & mask) && ++tried < MAX_SPI_WAIT_RETRIES); + } while (!ret && (val & mask) && ++tried < MAX_SPI_WAIT_RETRIES);
if (tried == MAX_SPI_WAIT_RETRIES) { msg_perr("Error: Time out on sending command.\n");
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40679 )
Change subject: lspcon_i2c_spi.c: Trivial style fix ......................................................................
Patch Set 1: Code-Review+2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40679 )
Change subject: lspcon_i2c_spi.c: Trivial style fix ......................................................................
Patch Set 1: Code-Review+2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40679 )
Change subject: lspcon_i2c_spi.c: Trivial style fix ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/flashrom/+/40679/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/40679/1//COMMIT_MSG@7 PS1, Line 7: lspcon_i2c_spi.c: Trivial style fix Add missing space
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/40679 )
Change subject: lspcon_i2c_spi.c: Trivial style fix ......................................................................
lspcon_i2c_spi.c: Trivial style fix
Change-Id: I0675b467d7b0d24626a336033668bf80bfeeb815 Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/40679 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: HAOUAS Elyes ehaouas@noos.fr --- M lspcon_i2c_spi.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified HAOUAS Elyes: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/lspcon_i2c_spi.c b/lspcon_i2c_spi.c index 1ee5f37..8de2c14 100644 --- a/lspcon_i2c_spi.c +++ b/lspcon_i2c_spi.c @@ -151,7 +151,7 @@ int ret = 0; do { ret |= lspcon_i2c_spi_read_register(fd, offset, &val); - } while(!ret && (val & mask) && ++tried < MAX_SPI_WAIT_RETRIES); + } while (!ret && (val & mask) && ++tried < MAX_SPI_WAIT_RETRIES);
if (tried == MAX_SPI_WAIT_RETRIES) { msg_perr("Error: Time out on sending command.\n");