Attention is currently required from: Martin L Roth, Thomas Heijligen, Arthur Heymans.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/74952 )
Change subject: flashrom: rename sb600spi.c to amd_spi.c ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1:
I actually like the name amd_something.c because it tells straight away that it's amd. Previously I had to map in my mind all the time sb600 -> oh that's amd. Now no need to do this "mapping" anymore! I also opened the patch you linked: it actually uses amd_spi100 so the same naming scheme as Martin introduces in this patch. What do you think?
On the slightly separate topic: if you think there is something in stable that you think worth cherry-picking, just go ahead, no problem! I remember at the beginning when stable started cherry-picking patches we settled on keeping "signed-off-by" line from original patch, and that was it. So I think it goes both ways. I remember there are unresolved questions about promontory support in this programmer.
-
Anastasia Klimchuk (Code Review)