Attention is currently required from: Kyösti Mälkki, Patrick Georgi, Patrick Rudolph.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78186?usp=email )
Change subject: ichspi: Add support for C740 PCH ......................................................................
Patch Set 4:
(3 comments)
Patchset:
PS4: Thanks for the patch! Jenkins fail looks temporary, should go away next time you rebase.
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/78186/comment/ab26b585_493fe6e8 : PS4, Line 1024: if (content->ISL <= 80) : return CHIPSET_C620_SERIES_LEWISBURG I am a bit confused, what happens with support for LEWISBURG ? Why are you just removing it?
I remember there were lots of debates two years ago, I tried to follow the chain of patches but there are lots of abandoned ones. I can understand this line might still need a fix. But it would be in a separate commit anyway? And if it's possible to fix, would be great to fix, instead of removing ?
https://review.coreboot.org/c/flashrom/+/78186/comment/5a27e98e_22bc5d8b : PS4, Line 490: to be compatible with 500 Series PCH below Maybe "to align with the SPI programming guide, which also conveniently makes it compatible with 500 Series PCH below" ? If SPI guide mentions 6 masters, you would keep it at 6 ?
-
Anastasia Klimchuk (Code Review)