Change in flashrom[master]: ichspi: Maximize usage of `ich_generation` global variable - flashrom-gerrit

17 Mar 2022


      Attention is currently required from: Nico Huber, Subrata Banik, Angel Pons, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62866 )
Change subject: ichspi: Maximize usage of `ich_generation` global variable
......................................................................
Patch Set 1: Code-Review-2
(1 comment)
Patchset:
PS1: 
Like I was saying internally, we want to do the opposite of this. We want functions *not* to be a closure of the global of ich_generation.
In other words, ich_generation should be a parameter to all functions that use it.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/62866
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7f37894b683196e741b6a95e290a68e83a550205
Gerrit-Change-Number: 62866
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Subrata Banik subratabanik@google.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Wed, 16 Mar 2022 23:15:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment