Attention is currently required from: Simon Buhrow, Alan Green, Nico Huber, Edward O'Callaghan, Samir Ibradžić.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/40477 )
Change subject: ft2232_spi.c: Pack WREN and op in one ftdi_write_data() call
......................................................................
Patch Set 25:
(2 comments)
Patchset:
PS25:
Hi Simon, thanks for the work and sorry for not responding for […]
I think I am one of these people, sorry!
First two lines in ft2232_spi_send_command has changed and now ft2232_spi_send_multicommand needs them as well. I will review this after rebase.
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/40477/comment/ac8ff0b3_428965b7
PS25, Line 295: 9
This is 12 now becaues the deassertion of CS# is also packed, AFAICS.
I counted 15 (lines 303, 309, 320, 328, 335). Can an optional read command also happen together with everything else?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/40477
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie4a07499ec5ef0af23818593f45dc427285a9e8a
Gerrit-Change-Number: 40477
Gerrit-PatchSet: 25
Gerrit-Owner: Simon Buhrow
Gerrit-Reviewer: Alan Green
avg@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Samir Ibradžić
sibradzic@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Simon Buhrow
Gerrit-Attention: Alan Green
avg@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Samir Ibradžić
sibradzic@gmail.com
Gerrit-Comment-Date: Sun, 18 Apr 2021 22:17:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment