Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67474 )
Change subject: flashrom.c: Drop emergency_help_message() after erasure ......................................................................
Patch Set 5:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67474/comment/8933a303_bb8af04a PS2, Line 10: agnostic
The principle idea suggested here is not at all unreasonable and had crossed my mind already however […]
It seems to me there are two questions here:
1) do we need to show emergency message when erase failed? (and the FIXME from many years ago thinks No we don't need) 2) where should help messages live, in cli_classic or in flashrom.c?
If the answer to 1) is No, then this patch can go ahead, and 2) can be discussed and decided completely independently of this patch.
If the answer to 1) is Yes then... I made an observation that `flashrom_image_write` has 3 callsites of `emergency_help_message()`. So moving the messages to cli_classic would need to take care of `flashrom_image_write`.
I would start with answering 1) Maybe instead of emergency message we can msg_gerr with the text similar to the text of FIXME?
-
Anastasia Klimchuk (Code Review)