Attention is currently required from: Nikolai Artemiev, Samantaz Fox, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change by Samantaz Fox. ( https://review.coreboot.org/c/flashrom/+/83969?usp=email )
Change subject: flashchips: Add definitions for Fudan FM25Q04, FM25Q64 and FM25Q128
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/83969/comment/1a52893c_275f69a7?usp... :
PS2, Line 6228: {2700, 3600}
As I wasn't really sure what to trust* and haven't done any testing to confirm that, I preferred to […]
Ah I see, thank you for the explanation!
Agree, let's leave it as is.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/83969?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I88fcc2bbb9706c8adb3722da6aa0e1d2d04c3fde
Gerrit-Change-Number: 83969
Gerrit-PatchSet: 2
Gerrit-Owner: Samantaz Fox
coding@samantaz.fr
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Samantaz Fox
coding@samantaz.fr
Gerrit-Comment-Date: Fri, 23 Aug 2024 02:01:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Samantaz Fox
coding@samantaz.fr