Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Miklós Márton, Thomas Heijligen.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75270?usp=email )
Change subject: doc: Add build instructions for NI-845x on Windows ......................................................................
Patch Set 5:
(1 comment)
File doc/dev_guide/building_from_source.rst:
https://review.coreboot.org/c/flashrom/+/75270/comment/6c4d629f_c7ac684b : PS5, Line 17: * linux-headers† : * libpci† : * libusb1† : * libftdi1† : * libjaylink† : * NI-845x driver & library package‡ : : | * optional, for building unit testing : | † optional, depending on the selected programmer : | ‡ optional, proprietary and Windows only. (See Windows build instructions)
How about using [Footnotes](https://www.sphinx-doc.org/en/master/usage/restructuredtext/basics. […]
I thought it made more sense to keep these near the list, since it seems unnecessarily difficult to scroll to the bottom of the page for these notes that don't really stand alone. It would be a different story if there were a footnote-but-place-it-after-this-paragraph construct, but there doesn't seem to be any such thing.
The paragraph above does the same thing, so if we wanted to debate such a change it seems like something to do in another commit (and change both of them).
-
Peter Marheine (Code Review)