David Hendricks has posted comments on this change. ( https://review.coreboot.org/25706 )
Change subject: linux_mtd: Initial import ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/25706/2/linux_mtd.c File linux_mtd.c:
https://review.coreboot.org/#/c/25706/2/linux_mtd.c@15 PS2, Line 15: * You should have received a copy of the GNU General Public License : * along with this program; if not, write to the Free Software : * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA This should go away as per https://review.coreboot.org/#/c/flashrom/+/25381/ .
https://review.coreboot.org/#/c/25706/2/linux_mtd.c@383 PS2, Line 383: msg_pdbg("%s: %s\n", __func__, ret == 0 ? "success." : "failed."); This could be made more helpful.