[S] Change in flashrom[master]: pcidev: remove pcidev_getdevfn() function - flashrom-gerrit

8 Mar 2023


      Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73570 )
Change subject: pcidev: remove pcidev_getdevfn() function
......................................................................
Patch Set 2:
(1 comment)
File board_enable.c:
https://review.coreboot.org/c/flashrom/+/73570/comment/c238cd2e_a2ab1241 
PS1, Line 1098: dev
...
Can `pci_get_dev` return null? previous version was checking for null.
I've moved the `pci_fill_info()` under the `if(!dev)` block. This has now the same effect to `pci_fill_info()` as in the code before.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/73570
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id2983420080f75ae6992edfb032bf5c83b29c803
Gerrit-Change-Number: 73570
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Wed, 08 Mar 2023 23:15:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment