[S] Change in flashrom[master]: programmer_init: Work on a mutable copy of programmer params

[Nico Huber (Code Review)]

Attention is currently required from: Felix Singer, Nico Huber, Thomas Heijligen, Anastasia Klimchuk.

Hello Felix Singer, build bot (Jenkins), Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Peter Marheine,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/flashrom/+/67094

to look at the new patch set (#3).

Change subject: programmer_init: Work on a mutable copy of programmer params
......................................................................

programmer_init: Work on a mutable copy of programmer params

The signature of extract_param() was wrong all the time. It actually
modifies the passed, global `programmer_param` string. This only com-
piled w/o warnings because of a deficiency of the strstr() API. It
takes a const string as argument but returns a mutable pointer to
a substring of it.

As we take a const parameter string in the libflashrom API and should
not change that, we create a copy in programmer_init() instead.

Change-Id: If6bb2e5e4312b07f756615984bd3757e92b86b0a
Signed-off-by: Nico Huber 
---
M flashrom.c
1 file changed, 32 insertions(+), 3 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/94/67094/3