Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Angel Pons, Nikolai Artemiev.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 )
Change subject: drivers: Move (un)map_flash_region to par/spi/opaque_master
......................................................................
Patch Set 9:
(3 comments)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/b518865e_8f4dc70d
PS8, Line 222: (
nit: `if (`
Done
https://review.coreboot.org/c/flashrom/+/67695/comment/314dc0ed_47876c73
PS8, Line 249: #if CONFIG_INTERNAL == 1
drop this || move inside symbol and make the `master_uses_physmap()` always available (see comment b […]
Done
https://review.coreboot.org/c/flashrom/+/67695/comment/614e52db_6022478d
PS8, Line 869: #if CONFIG_INTERNAL == 1
Not sure if `physical_memory` is always available. If it is, sure.
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/67695
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9c3df6ae260bcdb246dfb0cd8e043919609b014b
Gerrit-Change-Number: 67695
Gerrit-PatchSet: 9
Gerrit-Owner: Jonathon Hall
jonathon.hall@puri.sm
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Wed, 05 Oct 2022 12:36:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment