Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54712 )
Change subject: sb600spi.c: Move sb600_spibar into spi data instead of being global
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
I have a message to reviewers, below. Thank you!
File sb600spi.c:
https://review.coreboot.org/c/flashrom/+/54712/comment/1a8e13df_4f8b9de9
PS1, Line 610: free(data);
I am not quite sure whether I need to free sb600_data->sb600_spibar here. I wasn't freed before, and also it is mapped by rphysmap (not allocated).
But if it needs to be freed, I would better do this in this patch.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/54712
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifaad0f0a2c0e956029d2df18ddcfd092515ca3c0
Gerrit-Change-Number: 54712
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 20 May 2021 02:04:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment