[S] Change in flashrom[master]: ichspi.c: Retype appropiate variables with bool - flashrom-gerrit

2 Sep 2022


      Attention is currently required from: Nico Huber.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66892 )
Change subject: ichspi.c: Retype appropiate variables with bool
......................................................................
Patch Set 9:
(1 comment)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/66892/comment/cdf231bf_2a6758e4 
PS7, Line 872: 		write_cmd = true;
...
This looks odd. How could `true` be a command? (rhetorical question) […]
Agree, but that's something for another patch series. Marking as resolved.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/66892
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: If7eeacc44921f52aa593ab1302f17a5c5190f830
Gerrit-Change-Number: 66892
Gerrit-PatchSet: 9
Gerrit-Owner: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Comment-Date: Fri, 02 Sep 2022 10:19:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment