Attention is currently required from: Nico Huber, Subrata Banik, Angel Pons, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62868 )
Change subject: ichspi: Refactor Flashrom HW Sequencing Operation Part I
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62868/comment/20dbf823_6c60a490
PS1, Line 9: List of changes:
: 1. Introduced useful macros (read/write/erase/status etc.) and used
: throughout the SPI operations.
: 2. Drop unused macros.
: 3. SPI operations are using `control register (offset 0x6)` hence
: converted 32-bit reads into 16-bit read to cover the only hardware
: sequencing control register alone.
As commented in the pre-review this needs to be split up into multiple patches. […]
commit message is also misaligned with the patch content. For example (3) doesn't apply here?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62868
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3ea74b668e5f8d8e4b3da2a8ad8b81f1813e1e80
Gerrit-Change-Number: 62868
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Thu, 17 Mar 2022 01:58:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment