Attention is currently required from: Nico Huber, Subrata Banik, Paul Menzel, Edward O'Callaghan, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62867 )
Change subject: ichspi: Unify timeout (5sec) across all SPI operations
......................................................................
Patch Set 5:
(2 comments)
Patchset:
PS5:
Just curious, what was the reason for using two different timeouts?
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/62867/comment/459b2404_3534df0b
PS5, Line 33: /* Sunrise Point */
This "Sunrise Point" comment used to be above HSFS status bits macros, maybe it should be moved back to its place, if those macros are platform-specific?
Is ICH_HWSEQ_XFER_TIMEOUT_US Sunrise Point specific? (I don't think so).
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62867
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifa910dea794175d8ee2ad277549e5a0d69cba45b
Gerrit-Change-Number: 62867
Gerrit-PatchSet: 5
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 18 Mar 2022 04:25:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment