Attention is currently required from: Nico Huber, Subrata Banik, Angel Pons. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62282 )
Change subject: ichspi: Add Jasper Lake support ......................................................................
Patch Set 8:
(2 comments)
Patchset:
PS4:
Well it's different from EHL, but is it really new? It looks closer to the […]
Unresolving then because it does look like a pch300 although I am not 100% on every tiny idiosyncrasy.
If `ich_number_of_masters()` needs adjusting then so does the switch in `prettyprint_ich_descriptor_master()` too.
Thing is, that has: ``` const char *const master_names[] = { "BIOS", "ME", "GbE", "unknown", "EC", }; ``` but the datasheet says on page 42 - [BIOS, ME, GbE, EC] and states there are 4 masters. Nothing indicates if to interpret "number of masters" from the flash descriptor as so called- 0-based or 1-based. Therefore I just assumed `cont->NM`.
Open to some guidance here? My concern is that I got those two functions wrong.
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62282/comment/2df4901f_35436b88 PS8, Line 1061: CHIPSET_ELKHART_LAKE
EHL has CSSO 0x58. It's in the updated SPI Guide and was confirmed with […]
Thanks Nico that is super useful ! I didn't have access to EHL I was asking if Subrata could ask a contact to get that value out of band. I fixed the patch now to be explicit, I think that is a good strategy for the function to be total.