Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54990 )
Change subject: bitbang: Extend register_spi_bitbang_master() API with spi data
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
File bitbang_spi.c:
https://review.coreboot.org/c/flashrom/+/54990/comment/5cff25e5_2a184792
PS1, Line 164: mst.data = data;
: register_spi_master(&mst, NULL);
I feel like the removal of `mst.data = data;` and instead passing data directly into register_spi_master() is itself a patch. small granted but none the less technically not within the scope of this patch.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/54990
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I13e83ae74dbc3a3e79c84d1463683d360ff47bc0
Gerrit-Change-Number: 54990
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Thu, 27 May 2021 10:19:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment