Change in flashrom[master]: ich_descriptors.c: Ensure unsigned types >=0 on to prevent underflow ... - flashrom-gerrit

28 Mar 2022


      Attention is currently required from: Edward O'Callaghan, Angel Pons.
Light has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62764 )
Change subject: ich_descriptors.c: Ensure unsigned types >=0 on to prevent underflow error
......................................................................
Patch Set 14:
(1 comment)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62764/comment/17cd4d7a_a2d36b05 
PS14, Line 501: 			for (j = 0; j < (size_t)min(num_regions, 12); j++)
...
Maybe these `12`'s should be a `#define MAX_NUM_REGIONS 12` or at the very least a constant after li […]
I don't think it's the max number of regions as num_regions can be > 12. Can you suggest any other name for the macro.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/62764
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I5921cc571f3dca5188ca1973dba6ececbcbe2f39
Gerrit-Change-Number: 62764
Gerrit-PatchSet: 14
Gerrit-Owner: Light aarya.chaumal@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 28 Mar 2022 10:29:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment