[M] Change in flashrom[master]: spi.c: Add erasefn and opcodes for AT45 and S25F to lookup list
Attention is currently required from: Simon Buhrow, Nico Huber, Thomas Heijligen.
Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67354 )
Change subject: spi.c: Add erasefn and opcodes for AT45 and S25F to lookup list ......................................................................
Patch Set 10:
(10 comments)
File sfdp.c:
https://review.coreboot.org/c/flashrom/+/67354/comment/2be801a0_a9d02991 PS9, Line 85: erasefunc_t *erasefn = spi_get_erasefn_from_opcode(chip, opcode_list, 1);
You can use `spi_get_erasefn_from_opcode(chip, &opcode, 1)`
Done
File spi.c:
https://review.coreboot.org/c/flashrom/+/67354/comment/11ea319b_e6e2523e PS9, Line 32: sorted
what kind of sort?
Done
https://review.coreboot.org/c/flashrom/+/67354/comment/2b13f160_1615eaa8 PS9, Line 67: //Opcode lists must be sorted
It might be problematic that we only get a positive result if both opcode lists have the same order […]
If the function user passes the opcode_list in increasing order then it won't be a problem.
https://review.coreboot.org/c/flashrom/+/67354/comment/600a0112_5792962c PS9, Line 80: * Get the pointer to the erase function which uses passed opcodes and is used : * by the passed flashcip. This done by matching the opcodes from a lookup : * table and the erasefn in the passed flashchip.
There is no need to say how this is implemented. […]
Done
https://review.coreboot.org/c/flashrom/+/67354/comment/921efd0f_a7da2cff PS9, Line 87: */
`@result Pointer to erase function matching 'chip' and 'opcode_list' or NULL on failure`
Done
https://review.coreboot.org/c/flashrom/+/67354/comment/59e22e37_3a7c34be PS9, Line 99: info
s/info/err/
Done
https://review.coreboot.org/c/flashrom/+/67354/comment/248b7fce_c6373952 PS9, Line 107: the pointer to the array
`@result Null terminated array of opcodes used by the passd erase function.` […]
Done
https://review.coreboot.org/c/flashrom/+/67354/comment/ce368462_b5bc0224 PS9, Line 107: passd
passed
Done
https://review.coreboot.org/c/flashrom/+/67354/comment/25e0ed70_8ec0cd4e PS9, Line 108: This is done by matching the opcodes passed to the opcodes list in each entry : * of the lookup table.
The implementation is not relevant here
Done
https://review.coreboot.org/c/flashrom/+/67354/comment/d9ab9721_1d282960 PS9, Line 121: info
`s/info/err/` because when we are at this point it is an error.
Done
-
Aarya (Code Review)