Attention is currently required from: Thomas Heijligen.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66883 )
Change subject: flashrom.c: Retype appropriate variables with bool
......................................................................
Patch Set 12:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/66883/comment/990219eb_3e2c7646
PS12, Line 151: programmer_may_write = 1;
Right, I have done it in a follow up since multiple files need to be adjusted and so the commit title can't just be like
flashrom.c: retype some variables
It would have to be something like
tree: retype some variables
but this was too "much" for me and too unspecific. So I splitted up.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/66883
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I6629f391284c8f1266e4ba66c9976f3df43955d4
Gerrit-Change-Number: 66883
Gerrit-PatchSet: 12
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Comment-Date: Wed, 07 Sep 2022 10:26:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment