Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/30409 )
Change subject: Fix -Wsign-compare trouble ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/flashrom/+/30409/4/at45db.c File at45db.c:
https://review.coreboot.org/c/flashrom/+/30409/4/at45db.c@466 PS4, Line 466: flash->mst->spi.max_data_write - 4
Could this subtraction possibly underflow? Asking since there is the max_data_write > 0 check below.
Thanks. Deferred the calculation.
https://review.coreboot.org/c/flashrom/+/30409/4/dummyflasher.c File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/30409/4/dummyflasher.c@234 PS4, Line 234: %i
Should be %u now
Done
https://review.coreboot.org/c/flashrom/+/30409/4/dummyflasher.c@270 PS4, Line 270: %i
Should be %u now
Done
https://review.coreboot.org/c/flashrom/+/30409/4/print.c File print.c:
https://review.coreboot.org/c/flashrom/+/30409/4/print.c@331 PS4, Line 331: %d
Should be %u now
Done
-
Nico Huber (Code Review)