Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/28804 )
Change subject: dediprog: Enable 4BA support for SF600, protocol V2 ......................................................................
Patch Set 2:
(1 comment)
I've reduced this to the single path that is expected to work and tried to minimize changes. If somebody figures out more working combinations, I'd be happy to merged them. But I'll probably not work on this myself (unless my employment comes into play).
Even the Dediprog specification I got my hands on is worth less than a USB trace. It doesn't tell what is going on on the SPI side. It's probably easier to write proper firmware for these devices than to use what Dediprog ships.
https://review.coreboot.org/#/c/28804/1/dediprog.c File dediprog.c:
https://review.coreboot.org/#/c/28804/1/dediprog.c@399 PS1, Line 399: data_packet[13] = 0x00;
Perhaps. But at least I have one known good configuration. Let's start with that.
Done
-
Nico Huber (Code Review)