Attention is currently required from: Nico Huber, Angel Pons, Daniel Campello.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52383 )
Change subject: flashrom.c: allow - as filename for stdin/stdout
......................................................................
Patch Set 11:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/52383/comment/894cab58_351bebce
PS11, Line 9: Allows - as filename for -r/-w/-v options
Do add a rational here, perhaps something like - "It is sometimes useful to script flashrom and allowing it to work with pipes allows for more flexibility in this specific use-case." I guess would be something reasonable to say?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/52383
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I97889cfdf7ba9a257e182c4ee2b20075cfa58d4d
Gerrit-Change-Number: 52383
Gerrit-PatchSet: 11
Gerrit-Owner: Daniel Campello
campello@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Jack Rosenthal
jrosenth@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Daniel Campello
campello@chromium.org
Gerrit-Comment-Date: Mon, 19 Apr 2021 05:29:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment