Attention is currently required from: Miklós Márton, Thomas Heijligen.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75236 )
Change subject: meson: Add support for ni845x_spi on Windows ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File ni845x_spi.c:
https://review.coreboot.org/c/flashrom/+/75236/comment/7f16dbcf_62cd9ba6 PS4, Line 19: * Define it just here, since this driver will only work on 32-bit Windows. Does it make any more sense to make the build system define this? I believe NI assume that you're building with MSVC (which does define this symbol) so perhaps it makes more sense to let the buildsystem wrangle the library's assumptions?
It's probably not an important difference given the current limited support for compilers and platforms for this driver and flashrom as a whole, but putting the define in the build configuration would make potential future portability more convenient.
-
Peter Marheine (Code Review)