Attention is currently required from: Evan Benn.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71975 )
Change subject: flashrom_tester: Check WP range after setting it ......................................................................
Patch Set 6:
(4 comments)
File util/flashrom_tester/flashrom/src/cmd.rs:
https://review.coreboot.org/c/flashrom/+/71975/comment/60ff7b06_243d9441 PS6, Line 207: Range<usize> Is it possible for multiple ranges to be protected at the same time?
https://review.coreboot.org/c/flashrom/+/71975/comment/3cd73119_f57e6499 PS6, Line 227: \d `[[:xdigit:]]`
https://review.coreboot.org/c/flashrom/+/71975/comment/c0033693_91f1604a PS6, Line 231: range_match.get(1).unwrap().as_str() You can use `range_match[1]` to be more concise.
File util/flashrom_tester/flashrom/src/lib.rs:
https://review.coreboot.org/c/flashrom/+/71975/comment/ae2b6819_7afc693b PS6, Line 123: range "range of addresses that are protected" seems a little clearer.
-
Peter Marheine (Code Review)