Alan Green has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/34735 )
Change subject: flashchips: upstream changes to GD25LQ128 ......................................................................
flashchips: upstream changes to GD25LQ128
Change name of GD25LQ128 to GD25LQ128CD. This is an upstreaming of the change from the chromium flashrom repo SHA 6c957d745f5d3dcadd1035734a5cf1b804bd0f2f (Also visible at https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/+...)
The rationale from that change was:
The GD25LQ128C part is EOL. It's replacement is GD25LQ128D, but both chips identify in the same manner. Add GD25LQ128D to the name of the part so that it doesn't confused people.
Making this name consistent will simplify further merging from the chromium fork.
Change-Id: I57804f1a33170668e029a7b08ac050d9a3bd6dbb --- M flashchips.c M flashchips.h 2 files changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/35/34735/1
diff --git a/flashchips.c b/flashchips.c index f8d336e..c6f9517 100644 --- a/flashchips.c +++ b/flashchips.c @@ -5886,10 +5886,10 @@
{ .vendor = "GigaDevice", - .name = "GD25LQ128", + .name = "GD25LQ128C/GD25LQ128D", .bustype = BUS_SPI, .manufacture_id = GIGADEVICE_ID, - .model_id = GIGADEVICE_GD25LQ128, + .model_id = GIGADEVICE_GD25LQ128CD, .total_size = 16384, .page_size = 256, /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44 */ diff --git a/flashchips.h b/flashchips.h index 006b95e..7b8bf04 100644 --- a/flashchips.h +++ b/flashchips.h @@ -381,7 +381,7 @@ #define GIGADEVICE_GD25LQ16 0x6015 #define GIGADEVICE_GD25LQ32 0x6016 #define GIGADEVICE_GD25LQ64 0x6017 /* Same as GD25LQ64B (which is faster) */ -#define GIGADEVICE_GD25LQ128 0x6018 +#define GIGADEVICE_GD25LQ128CD 0x6018 #define GIGADEVICE_GD29GL064CAB 0x7E0601
#define HYUNDAI_ID 0xAD /* Hyundai */
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34735 )
Change subject: flashchips: upstream changes to GD25LQ128 ......................................................................
Patch Set 1: Code-Review+2
Edward O'Callaghan has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/34735 )
Change subject: flashchips: upstream changes to GD25LQ128 ......................................................................
flashchips: upstream changes to GD25LQ128
Change name of GD25LQ128 to GD25LQ128CD. This is an upstreaming of the change from the chromium flashrom repo SHA 6c957d745f5d3dcadd1035734a5cf1b804bd0f2f (Also visible at https://chromium-review.googlesource.com/c/chromiumos/third_party/flashrom/+...)
The rationale from that change was:
The GD25LQ128C part is EOL. It's replacement is GD25LQ128D, but both chips identify in the same manner. Add GD25LQ128D to the name of the part so that it doesn't confused people.
Making this name consistent will simplify further merging from the chromium fork.
Change-Id: I57804f1a33170668e029a7b08ac050d9a3bd6dbb Reviewed-on: https://review.coreboot.org/c/flashrom/+/34735 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M flashchips.c M flashchips.h 2 files changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved
diff --git a/flashchips.c b/flashchips.c index f8d336e..c6f9517 100644 --- a/flashchips.c +++ b/flashchips.c @@ -5886,10 +5886,10 @@
{ .vendor = "GigaDevice", - .name = "GD25LQ128", + .name = "GD25LQ128C/GD25LQ128D", .bustype = BUS_SPI, .manufacture_id = GIGADEVICE_ID, - .model_id = GIGADEVICE_GD25LQ128, + .model_id = GIGADEVICE_GD25LQ128CD, .total_size = 16384, .page_size = 256, /* OTP: 1024B total, 256B reserved; read 0x48; write 0x42, erase 0x44 */ diff --git a/flashchips.h b/flashchips.h index 006b95e..7b8bf04 100644 --- a/flashchips.h +++ b/flashchips.h @@ -381,7 +381,7 @@ #define GIGADEVICE_GD25LQ16 0x6015 #define GIGADEVICE_GD25LQ32 0x6016 #define GIGADEVICE_GD25LQ64 0x6017 /* Same as GD25LQ64B (which is faster) */ -#define GIGADEVICE_GD25LQ128 0x6018 +#define GIGADEVICE_GD25LQ128CD 0x6018 #define GIGADEVICE_GD29GL064CAB 0x7E0601
#define HYUNDAI_ID 0xAD /* Hyundai */
-
Alan Green (Code Review) -
Edward O'Callaghan (Code Review)