Attention is currently required from: Aarya, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78492?usp=email )
Change subject: erasure_layout: Add region boundaries to printed info message ......................................................................
Patch Set 2:
(1 comment)
File erasure_layout.c:
https://review.coreboot.org/c/flashrom/+/78492/comment/31b0a7ca_a5018705 : PS1, Line 177: msg_cinfo("Region start 0x%08x not sector aligned! Extending start boundaries by 0x%08x.\n",
maybe write "Extending start boundaries by 0x%08x bytes. […]
I added "bytes" thank you, good idea. This patch came up in process of debugging https://ticket.coreboot.org/issues/494 , you are very welcome to have a look and say what you think about it! If you look my last comment, with 1-line change in existing test, the issue can repro (test fails). So you don't even need images or any hardware. At the end I will add a proper test to cover this case, but for debugging phase, changing 1 line of code should be fine :)