Attention is currently required from: Dmitry Zhadinets, Peter Marheine.
Anastasia Klimchuk has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/87251?usp=email )
Change subject: libflashrom: Add API for capabilitible chips ......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS2:
It turns out that DUMMY is disabled in some cases. […]
Sorry for some delay, while you asked for help.
I read the comment and info in commit message, it seems there are few questions?
1) what happened in spi test, you said there is a bug? do you have error logs? I will try to repro. It's good if you found bug in another test, it can go in a separate commit
2) dummy has several options what to emulate (see https://github.com/flashrom/flashrom/blob/main/dummyflasher.c#L31, string values in the code https://github.com/flashrom/flashrom/blob/main/dummyflasher.c#L1216) and one of them has duplicate IDs as of now. I forgot which one, probably EMULATE_MACRONIX_MX25L6436. If you emulate it should find two matches in flashchips.
3) I still want to create a patch for probing v2, but it will need test as well, so tests are useful anyway.
-
Anastasia Klimchuk (Code Review)