David Hendricks has posted comments on this change. ( https://review.coreboot.org/18738 )
Change subject: Fix linking with libpayload ......................................................................
Patch Set 6: Code-Review-1
(2 comments)
The patch is OK, I'm just curious why we don't move flashbuses_to_text() into flashrom.c so the print can work consistently.
https://review.coreboot.org/#/c/18738/6//COMMIT_MSG Commit Message:
PS6, Line 9: o flashbuses_to_text() is a cli function and should actually be moved : or not be called from flashrom.c. Why not move flashbuses_to_text() to flashrom.c?
https://review.coreboot.org/#/c/18738/6/helpers.c File helpers.c:
Line 95: #if defined(__DJGPP__) Hmm, I wonder if it's still useful to have a check for glibc compatibility while we're at it. According to the man page: Since glibc 2.10: _POSIX_C_SOURCE >= 200809L Before glibc 2.10: _GNU_SOURCE