Nico Huber has posted comments on this change. ( https://review.coreboot.org/23022 )
Change subject: make args for -r/-w/-v non-positional and optional
......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/#/c/23022/13/cli_classic.c
File cli_classic.c:
https://review.coreboot.org/#/c/23022/13/cli_classic.c@601
PS13, Line 601: This is checked later since it requires
: * processing the layout/fmap first.
It is checked later indeed. But the layout is already processed
here, AFAICS.
--
To view, visit
https://review.coreboot.org/23022
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iefbcb7dc4fefe26f5afd1292dfd5c1687fa62803
Gerrit-Change-Number: 23022
Gerrit-PatchSet: 13
Gerrit-Owner: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Louis Yung-Chieh Lo
yjlou@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 24 Jun 2018 18:28:29 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No