Attention is currently required from: Felix Singer, Nico Huber, Paul Menzel, Angel Pons, Light.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62724 )
Change subject: pony_spi.c: Fix memory leak in function pony_init_spi
......................................................................
Patch Set 7: Code-Review+1
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/62724/comment/f304e532_cb8eef74
PS3, Line 11: ii
Done
This seems to be still in the latest patchset? Still 2 ii in "deallocatiing".
Commit Message:
https://review.coreboot.org/c/flashrom/+/62724/comment/a7b6b27f_b5c169ec
PS7, Line 9: Memory leaked was caused
I think "Memory leak was caused" sounds better (memory leak instead of memory leaked).
Patchset:
PS7:
I have just 2 comments about commit message.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/62724
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7910db94f63693e7f131836d4963e88cfdbec301
Gerrit-Change-Number: 62724
Gerrit-PatchSet: 7
Gerrit-Owner: Light
aarya.chaumal@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Martin L Roth
martinroth@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Light
aarya.chaumal@gmail.com
Gerrit-Comment-Date: Mon, 14 Mar 2022 08:23:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Light
aarya.chaumal@gmail.com
Gerrit-MessageType: comment