Change in flashrom[master]: lspcon_i2c_spi: Extract I2C bus parameter handling - flashrom-gerrit

3 May 2021


      Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/52830 )
Change subject: lspcon_i2c_spi: Extract I2C bus parameter handling
......................................................................
Patch Set 1:
(1 comment)
File i2c_helper_linux.c:
https://review.coreboot.org/c/flashrom/+/52830/comment/a113fbe7_f0fbf72d 
PS1, Line 80: * TODO: Move this function to a common place, it is not specific to I2C */
...
If one removes all the references to "bus" from this function, what remains is a function that parse […]
Just drop it all together I suppose.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/52830
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I006b311c88feea37fe4b217f769b21ca1505def9
Gerrit-Change-Number: 52830
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Peter Marheine pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Mon, 03 May 2021 11:59:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment