Attention is currently required from: David Wu, Edward O'Callaghan, Evan Benn, Hsuan Ting Chen, Hsuan-ting Chen.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/79304?usp=email )
Change subject: flashrom_tester: Fix partial_lock_test on libflashrom
......................................................................
Patch Set 3:
(4 comments)
Patchset:
PS3:
Ed, Evan, thank you so much for reviews! Could you please vote on the patch?
PS3:
Hi Anastasia, […]
Sure!
I looked at this, but we need to try get votes on the patch from Ed and/or Evan, they have knowledge of the stuff.
File util/flashrom_tester/Cargo.toml:
https://review.coreboot.org/c/flashrom/+/79304/comment/a0f95b87_0d53b186 :
PS3, Line 25: libflashrom = { path = "../../bindings/rust/libflashrom" }
I am curious: why it was working before, without this line?
File util/flashrom_tester/flashrom/src/cmd.rs:
https://review.coreboot.org/c/flashrom/+/79304/comment/fe975616_e2c1e92d :
PS3, Line 301: // TODO
Did you mean to do something here?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/79304?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I7a8ac0c0984fef3cd9e73ed8d8097ddf429e54b2
Gerrit-Change-Number: 79304
Gerrit-PatchSet: 3
Gerrit-Owner: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Evan Benn
evanbenn@gmail.com
Gerrit-Reviewer: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nikolai Artemiev
nartemiev@chromium.org
Gerrit-Attention: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Evan Benn
evanbenn@gmail.com
Gerrit-Attention: Hsuan-ting Chen
roccochen@google.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Mon, 15 Jan 2024 04:18:52 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Hsuan-ting Chen
roccochen@google.com
Gerrit-MessageType: comment