Attention is currently required from: Peter Marheine, Richard Hughes, Sergii Dmytruk.
Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/86031?usp=email )
Change subject: libflashrom: Update the API for progress callback ......................................................................
Patch Set 7:
(2 comments)
File include/libflashrom.h:
https://review.coreboot.org/c/flashrom/+/86031/comment/96ae1b25_b8a2b30c?usp... : PS2, Line 90: * @deprecated Use flashrom_set_progress_callback_v1 instead
There could still be a pointer to a client-managed progress state along with the internal state, just need to copy data into the former before invoking v1 callback.
It is also clever and it works! I made the last patchset with this solution. Thank you!
And then, I will keep in mind that it will be possible to remove the deprecated code in v2.0
Thank you for link to repology.org, it was very interesting for me to look at flashrom package :) For libflashrom, I understand there are not many users but anyway I am happy that we have solution that doesn't break anyone.
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/86031/comment/e2ea7380_78f0cae2?usp... : PS5, Line 70: flashctx->progress_state = progress_state;
This line is no longer possible , with the change in line 625 in include/flash. […]
Done
-
Anastasia Klimchuk (Code Review)