[S] Change in flashrom[master]: buspirate_spi.c: Call free() on a pointer only if it's not NULL - flashrom-gerrit

27 Sep 2022


      Attention is currently required from: Felix Singer.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67890 )
Change subject: buspirate_spi.c: Call free() on a pointer only if it's not NULL
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67890/comment/d156acd6_2f9cdf4e 
PS1, Line 7: buspirate_spi.c: Call free() on a pointer only if it's not NULL
Why? The C99 spec from https://www.open-std.org/jtc1/sc22/wg14/www/docs/n1256.pdf says that `free(NULL)` is valid and has no effect.
https://imgur.com/OdpOmnb.png
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/67890
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I48e1621589cf84156a8849458ab2a8a8499bb427
Gerrit-Change-Number: 67890
Gerrit-PatchSet: 1
Gerrit-Owner: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Comment-Date: Tue, 27 Sep 2022 12:05:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment