Attention is currently required from: DZ, Nikolai Artemiev, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81836?usp=email )
Change subject: flashchips: Add support for MXIC MX25L1633E
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/81836/comment/be3b8c1b_1f6251fa :
PS3, Line 9280: MACRONIX_MX25L1635D
Just one thing here: if you can please mention new chip MX25L1633E in a comment to existing macro MACRONIX_MX25L1635D in flashchips.h. Thanks!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/81836?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I63ee0182ad6e62b7408136285aa0e927d53f7bc8
Gerrit-Change-Number: 81836
Gerrit-PatchSet: 3
Gerrit-Owner: DZ
danielzhang@mxic.com.cn
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: DZ
danielzhang@mxic.com.cn
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Sat, 13 Apr 2024 08:17:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment