Attention is currently required from: Nico Huber. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55651 )
Change subject: ich_descriptors: Normalize chipset detection ......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS5: This patch added an undocumented assumption that Ibex Peak will have the most straps in the `ICCRIBA == 0x00` case, which we now know is not true. I've fixed that assumption in CB:57633.
The other change in this patch looks suspicious as well. Perhaps we should just revert this whole patch?
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/55651/comment/27a193c4_ceb891a7 PS5, Line 936: if (content->ISL <= 16) : return CHIPSET_5_SERIES_IBEX_PEAK; Removing this adds an implicit assumption that chipsets added later on will not have more straps than Ibex Peak, which is not true (as we now know).
https://review.coreboot.org/c/flashrom/+/55651/comment/a81d858f_bfb6a025 PS5, Line 953: return CHIPSET_8_SERIES_LYNX_POINT; : warn_peculiar_desc(true, "Wildcat Point"); : return CHIPSET_9_SERIES_WILDCAT_POINT; The commit message says "Always end with the newest, assumed compatible chipset." Isn't CHIPSET_9_SERIES newer than CHIPSET_8_SERIES? Or is there some incompatibility with the 9-series that is not mentioned here?
-
David Hendricks (Code Review)