Attention is currently required from: Felix Singer, Angel Pons.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71622 )
Change subject: dmi.c: Pass is_laptop by ref into dmi
......................................................................
Patch Set 2:
(2 comments)
File dmi.c:
https://review.coreboot.org/c/flashrom/+/71622/comment/a9ea2717_0d92df76
PS1, Line 158: *is_laptop = 2;
For another patch: This should be an enum.
I improved upon the patch to at least make it a return value. Thanks for the review.
https://review.coreboot.org/c/flashrom/+/71622/comment/c6b4986d_89ed23d7
PS1, Line 402: is_laptop
nit: update comment too?
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/71622
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3d5ad6c0623269492d775a99a947fd6fe26c5f91
Gerrit-Change-Number: 71622
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Thu, 12 Jan 2023 03:19:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment