Nico Huber has posted comments on this change. ( https://review.coreboot.org/20250 )
Change subject: fixup of "Kill doit()" ......................................................................
Patch Set 1:
(1 comment)
Well, you can fix up the commit message after you got your Change-Id... Hmmm, I used this once, don't remember any trouble though. Maybe I used a different commit-msg hook, dunno.
https://review.coreboot.org/#/c/20250/1/cli_classic.c File cli_classic.c:
https://review.coreboot.org/#/c/20250/1/cli_classic.c@556 PS1, Line 556: #if CONFIG_INTERNAL == 1 Ugh, guards...
How about moving the `force_boardmismatch` declaration and definition out of their respective guards?