Change in flashrom[master]: nic3com.c: Refactor singleton states into reentrant pattern - flashrom-gerrit

9 Jun 2021


      Attention is currently required from: Nico Huber, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55107 )
Change subject: nic3com.c: Refactor singleton states into reentrant pattern
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS2:
...
Oh no, looks like I created a mess :( This patch is the right one, another one is duplicate. […]
I added init_err_cleanup_exit label, so now there is a cleanup. I didn't call shutdown function because it is freeing data, but this is not needed for one of error paths. Code under init_err_cleanup_exit can just use local variables.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/55107
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I9834b82650cd070556cf82207796bc6bd6b31b28
Gerrit-Change-Number: 55107
Gerrit-PatchSet: 4
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 09 Jun 2021 02:47:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment