Attention is currently required from: Nico Huber, David Hendricks, Angel Pons, Arthur Heymans. Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/61943 )
Change subject: libflashrom/fmap: Don't use off_t for flash offsets ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
It seems you are burdening yourself with too much knowledge :) I generally like […]
Well, I think we both agree that the difference is miniscule, I just like to err on fixed width as the default unless reason to do otherwise (<stdint.h> is also "standard C", after all). If all we care about is that it can hold -2^31 to 2^31-1, then I think that means exactly that int32_t should be the right size, and not long.
If you're worried about 32Gbit not being enough, then I think that would make long an even worse choice, because then whether a certain flash chip works or breaks depends on what environment flashrom is running under, which is not a good situation to be in. In that case, int64_t would be the right type to use. (I don't think it's necessary to go there yet but I'm happy to compromise on that if people think otherwise.)
-
Julius Werner (Code Review)