[S] Change in flashrom[master]: writeprotect.c: move wp_bits -> register values/masks conversion into...
Attention is currently required from: Nikolai Artemiev, Sergii Dmytruk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69846 )
Change subject: writeprotect.c: move wp_bits -> register values/masks conversion into func ......................................................................
Patch Set 1: Code-Review+2
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/69846/comment/c5c998d3_c817216c PS1, Line 7: move wp_bits -> register values/masks conversion into func "Split out reg mask/val calculations into pure func"
https://review.coreboot.org/c/flashrom/+/69846/comment/68c11620_8f1642e7 PS1, Line 11: . "This avoids monadic transformer stacks where unit-testing cannot penetrate well to give suitable coverage, therefore keep the pure bit logic in a separate function without side-effects."
https://review.coreboot.org/c/flashrom/+/69846/comment/77efe15d_280ea5ff PS1, Line 13: TEST=ninja test `BUG=b:259013033`
-
Edward O'Callaghan (Code Review)