Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/63470 )
Change subject: ichspi: Use `pprint_reg` macro for PCH100 HSFC FCYCLE offset ......................................................................
ichspi: Use `pprint_reg` macro for PCH100 HSFC FCYCLE offset
This patch uses `pprint_reg` macro instead `_pprint_reg` with explicit register name and offset macros being passed as argument.
BUG=b:223630977 TEST=Able to display PCH100_HSFC.FCYCLE offset properly.
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: I5a8d84639b7226bf82458a7310f306c5232cffe3 Reviewed-on: https://review.coreboot.org/c/flashrom/+/63470 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Anastasia Klimchuk aklm@chromium.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Nico Huber nico.h@gmx.de --- M ichspi.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Arthur Heymans: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved
diff --git a/ichspi.c b/ichspi.c index 36ee3b9..999249d 100644 --- a/ichspi.c +++ b/ichspi.c @@ -463,7 +463,7 @@ case CHIPSET_400_SERIES_COMET_POINT: case CHIPSET_500_SERIES_TIGER_POINT: case CHIPSET_ELKHART_LAKE: - _pprint_reg(HSFC, PCH100_HSFC_FCYCLE, PCH100_HSFC_FCYCLE_OFF, reg_val, ", "); + pprint_reg(PCH100_HSFC, FCYCLE, reg_val, ", "); pprint_reg(PCH100_HSFC, WET, reg_val, ", "); break; default: