Attention is currently required from: Nico Huber, Angel Pons. Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62851 )
Change subject: hwaccess_x86_msr: rename rdmsr, wrmsr to read_cpu_msr, write_cpu_msr ......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
I first thought, it's called rdmsr/wrmsr everywhere, so we might […]
IMO the new function names are close enough to the originals and straightforward to understand. We have no need to shorten each symbol to the minimal size to fit everything in 80 characters. let's make readable code.
File hwaccess_x86_msr.c:
https://review.coreboot.org/c/flashrom/+/62851/comment/9a37f3af_3cdb8067 PS1, Line 296: /* rdmsr() and wrmsr() are provided by DirectHW which needs neither setup nor cleanup. */
Do we have all necessary #include's in this file, though?
I don't know. I've never tried directwh. You need xcode to compile it and it might be not working on current macos versions. This might also not the only issue with directhw. Nevertheless I'll give it a try.