Attention is currently required from: Nico Huber, Michał Żygowski, Jonathan Zhang, Angel Pons. David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57793 )
Change subject: ich_descriptors: Add explicit checks for all chipsets ......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/57793/comment/9d7aa624_a574e8a4 PS3, Line 10: A new chipset : was added that necessitated adding back a check for an older : chipset.
That's not accurate. It was the way that the new check was written […]
I've reworded this to focus on what's being done in this patch. If somebody wants more context they can easily find it in the commit mentioned in the previous sentence.
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/57793/comment/badc142e_6d1f4a48 PS1, Line 968: if (content->ICCRIBA != 0x34) : msg_pwarn("Unknown flash descriptor, assuming 300 series compatibility.\n");
This one had a different message.
"Unknown flash descriptor, assuming 300 series compatibility" and "Peculiar flash descriptor, assuming 300 series compatibility" mean the same thing. Both are msg_pwarn(), too.
Regardless, this is not worth splitting hairs so I've reverted back to using msg_pwarn() since you seem to prefer it that way.
-
David Hendricks (Code Review)