Attention is currently required from: Angel Pons, Sergii Dmytruk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59071 )
Change subject: flashchips: enable write-protection for W25Q{64,128}.V
......................................................................
Patch Set 25:
(2 comments)
Patchset:
PS15:
This seems resolved, just checking, does everyone agree this is resolved?
Ack
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/59071/comment/fa52acaa_9312ed39
PS25, Line 18017: W25Q64JV
We already have the same name in the entry below (with a different
.model_id). As I understand the datasheet, this one should be
"W25Q64JV-.Q" and the other one "W25Q64JV-.M".
--
To view, visit
https://review.coreboot.org/c/flashrom/+/59071
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iccb69a8d3a0dd2192e2c938caddaf07b1889ed35
Gerrit-Change-Number: 59071
Gerrit-PatchSet: 25
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Tue, 05 Apr 2022 10:42:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-MessageType: comment