Change in flashrom[staging]: chipset_enable: Add support for Intel Skylake / Kabylake - flashrom-gerrit

27 Jul 2017


      Nico Huber has posted comments on this change. ( https://review.coreboot.org/18925 )
Change subject: chipset_enable: Add support for Intel Skylake / Kabylake
......................................................................
Patch Set 8:
...
The RPCI fix is pushed here : https://review.coreboot.org/#/c/20784/
Now all we need is for this patch to set the 'pacc' variable and
restore it at the end of the function.
Um, I don't see why I have to wait for a seven years old bug to get
fixed before I add another chipset... also, if we fix it here and not
in your patch, we'll lose the explicit information that the changes
are related (e.g. if anyone will ever fix the rpci interface he'll
more likely miss to remove the workaround here).
-- 
To view, visit https://review.coreboot.org/18925
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: staging
Gerrit-MessageType: comment
Gerrit-Change-Id: I000819aff25fbe9764f33df85f040093b82cd948
Gerrit-Change-Number: 18925
Gerrit-PatchSet: 8
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Stefan Tauner stefan.tauner@gmx.at
Gerrit-Reviewer: Youness Alaoui snifikino@gmail.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 27 Jul 2017 11:32:26 +0000
Gerrit-HasComments: No